Refactor multi-selection expression evaluation logic#1
Closed
RealMalWare wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, each selection range was appended to an ever-growing buffer. So StringCchCatA had to search for the end of the buffer every single time. In addition, character set conversion and currency cleanup were performed again on the growing buffer in each iteration.
This became very slow when dealing with large rectangular selections -->many ranges.
The fix stores the current write position in the buffer using
bufPos. New sections are written directly to this position usingmemcpy.In addition, character set conversion and currency cleanup are now performed only once after the loop.
The behavior remains the same:
Multiple selected numbers are still combined into a single expression, for example, "1", "2", "3" into "1+2+3".